-
Notifications
You must be signed in to change notification settings - Fork 252
Truncate long test names in assets. #210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for this PR @D3X! Do you happen to have a screenshot of what a report looks like (before and after) when using this? What I'm looking for is that the truncation doesn't happen at the end of the name, but rather in the middle or start. To illustrate. I don't want these: to become: but rather: or: Hope that makes sense! 😊 |
|
Oh wait... You're talking about filename and not testname... right? 🙈 |
|
@BeyondEvil um, yes, filenames. Perhaps I should've worded that differently :) (force-pushed a fix for flake8 complaints) |
|
@D3X Nothing wrong with your wording, I just have to learn how to read. 😂 This is awesome! Just because I'm curious, did you see an issue where the original functionality broke? As soon as tests pass, I'll approve! 👍 |
|
@BeyondEvil yes, our test suite was broken because of that, that's why I created this PR. Nested test classes + long test method names + parametrization = looooong test names = |
|
@D3X WOW! That's... impressive! 😊 |
|
@D3X When this is merged I'll make a hotfix release tonight or tomorrow, because this is a bug. 👍 |
BeyondEvil
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
I'll leave the honors to you @D3X. Unless you take too long. ;) |
|
@BeyondEvil I don't think I have access to merge, so go ahead :) |
Truncate long test names in assets.
|
@D3X Version 1.21.1 is out with your fix! Thanks! 👍 |
When a test name is long (that might include class hierarchy and parametrization), the generated filename may exceed max supported length.
This PR truncates long names to avoid that, while preserving hashes of non-truncated names.